Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8305 )
Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src. ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/8305/8/be/src/util/time.h File be/src/util/time.h: http://gerrit.cloudera.org:8080/#/c/8305/8/be/src/util/time.h@106 PS8, Line 106: /// Convenience function to return the date-time string of the current time : /// derived from UnixMicros(). > how about we mention that this is in the local time zone. Changed the wording to say that the date-time string conversion is in the local time zone. -- To view, visit http://gerrit.cloudera.org:8080/8305 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I642a1d713597826bb7c15cd2ecb6638cb813a02c Gerrit-Change-Number: 8305 Gerrit-PatchSet: 8 Gerrit-Owner: Zoram Thanga <zo...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Mon, 23 Oct 2017 19:15:16 +0000 Gerrit-HasComments: Yes