Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8146 )
Change subject: IMPALA-5307: Part 2: copy out strings in uncompressed Avro ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/8146/11/be/src/runtime/tuple.h File be/src/runtime/tuple.h: http://gerrit.cloudera.org:8080/#/c/8146/11/be/src/runtime/tuple.h@289 PS11, Line 289: ); > Looking in the IR I noticed that there were "invoke" instruction emitted wh Are those calls to std C++ library functions ? http://gerrit.cloudera.org:8080/#/c/8146/11/be/src/runtime/tuple.cc File be/src/runtime/tuple.cc: http://gerrit.cloudera.org:8080/#/c/8146/11/be/src/runtime/tuple.cc@449 PS11, Line 449: Value* result_val = builder.CreateCall(cross_compiled_fn, > I think being conservative is probably a good thing actually. The code is n Yes. That seems to be helpful. Can we also do something bigger (e.g. 16 columns) ? If I understand it correctly, the benefit for codegen'ing here (and all the new code for creating the constants) is for unrolling the loop, right ? May be it's still helpful for the cases in which few number of string columns are materialized. -- To view, visit http://gerrit.cloudera.org:8080/8146 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If1fc78790d778c874f5aafa5958c3c045a88d233 Gerrit-Change-Number: 8146 Gerrit-PatchSet: 11 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 24 Oct 2017 00:37:51 +0000 Gerrit-HasComments: Yes
