Hello Lars Volker, Michael Brown, Matthew Jacobs, Philip Zeyliger, anujphadke,
I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/8038 to look at the new patch set (#14). Change subject: IMPALA-5736: Add impala-shell argument to set default query options ...................................................................... IMPALA-5736: Add impala-shell argument to set default query options Query options can be set from command line and impala rc as key=value pairs, where key is case insensitive. Examples: command line: impala-shell.sh -Q MT_DOP=1 --query_option=MAX_ERRORS=200 .impalarc: [impala.query_options] EXPLAIN_LEVEL=2 MT_DOP=2 The options set in command line will update the ones in impalarc one by one, so the result of the example above will be: EXPLAIN_LEVEL=2 MT_DOP=1 MAX_ERRORS=200 Additional changes: - 0 and 1 are accepted as bools in section [impala] to make it more consistent with [impala.query options] - options that are expected to be bool but are not 0/1/true/false lead to error instead of warning Change-Id: I26a3b67230c80a99bd246b6af205d558fec9a986 --- M shell/impala_shell.py M shell/option_parser.py A tests/shell/impalarc_with_error A tests/shell/impalarc_with_query_options A tests/shell/impalarc_with_warnings M tests/shell/test_shell_commandline.py M tests/shell/test_shell_interactive.py 7 files changed, 140 insertions(+), 43 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/38/8038/14 -- To view, visit http://gerrit.cloudera.org:8080/8038 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I26a3b67230c80a99bd246b6af205d558fec9a986 Gerrit-Change-Number: 8038 Gerrit-PatchSet: 14 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <mjac...@apache.org> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com>