Michael Ho has posted comments on this change. ( http://gerrit.cloudera.org:8080/8023 )
Change subject: IMPALA-4856: Port data stream service to KRPC ...................................................................... Patch Set 6: (15 comments) http://gerrit.cloudera.org:8080/#/c/8023/6/be/src/runtime/krpc-data-stream-sender.cc File be/src/runtime/krpc-data-stream-sender.cc: http://gerrit.cloudera.org:8080/#/c/8023/6/be/src/runtime/krpc-data-stream-sender.cc@123 PS6, Line 123: until : // any in-flight RPC completes if the preceding RPC is still in-flight. http://gerrit.cloudera.org:8080/#/c/8023/6/be/src/runtime/krpc-data-stream-sender.cc@135 PS6, Line 135: free frees http://gerrit.cloudera.org:8080/#/c/8023/6/be/src/runtime/krpc-data-stream-sender.cc@258 PS6, Line 258: stack code http://gerrit.cloudera.org:8080/#/c/8023/6/be/src/runtime/krpc-data-stream-sender.cc@261 PS6, Line 261: stack code http://gerrit.cloudera.org:8080/#/c/8023/6/be/src/runtime/krpc-data-stream-sender.cc@264 PS6, Line 264: thread threads http://gerrit.cloudera.org:8080/#/c/8023/6/be/src/runtime/krpc-data-stream-sender.cc@279 PS6, Line 279: thread threads http://gerrit.cloudera.org:8080/#/c/8023/6/be/src/runtime/row-batch.h File be/src/runtime/row-batch.h: http://gerrit.cloudera.org:8080/#/c/8023/6/be/src/runtime/row-batch.h@104 PS6, Line 104: CachedProtobufRowBatch OutboundRowBatch http://gerrit.cloudera.org:8080/#/c/8023/6/be/src/runtime/row-batch.h@144 PS6, Line 144: /// Populate a row batch from a serialized protobuf input_batch by copying : /// input_batch's tuple_data into the row batch's mempool and converting all : /// offsets in the data back into pointers. stale http://gerrit.cloudera.org:8080/#/c/8023/6/be/src/runtime/row-batch.h@455 PS6, Line 455: tuple_offsets input_* http://gerrit.cloudera.org:8080/#/c/8023/6/be/src/runtime/row-batch.h@531 PS6, Line 531: CachedProtobufRowBatch OutboundProtoRowBatch http://gerrit.cloudera.org:8080/#/c/8023/6/be/src/util/network-util.cc File be/src/util/network-util.cc: http://gerrit.cloudera.org:8080/#/c/8023/6/be/src/util/network-util.cc@41 PS6, Line 41: using kudu::Sockaddr; undo. Bad rebase. http://gerrit.cloudera.org:8080/#/c/8023/6/be/src/util/network-util.cc@120 PS6, Line 120: Sockaddr sock; undo http://gerrit.cloudera.org:8080/#/c/8023/6/common/protobuf/data_stream_service.proto File common/protobuf/data_stream_service.proto: http://gerrit.cloudera.org:8080/#/c/8023/6/common/protobuf/data_stream_service.proto@38 PS6, Line 38: 'tuple_offsets' tuple offsets' buffer http://gerrit.cloudera.org:8080/#/c/8023/6/common/protobuf/data_stream_service.proto@43 PS6, Line 43: 'tuple_data' tuple data's buffer http://gerrit.cloudera.org:8080/#/c/8023/6/common/protobuf/row_batch.proto File common/protobuf/row_batch.proto: http://gerrit.cloudera.org:8080/#/c/8023/6/common/protobuf/row_batch.proto@25 PS6, Line 25: The indices of the sidecars are included in the header below. delete -- To view, visit http://gerrit.cloudera.org:8080/8023 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic0b8c1e50678da66ab1547d16530f88b323ed8c1 Gerrit-Change-Number: 8023 Gerrit-PatchSet: 6 Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Fri, 27 Oct 2017 22:41:44 +0000 Gerrit-HasComments: Yes
