Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/8410 )
Change subject: IMPALA-6118: Fix assertion failure in coordinator bloom filter updating ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/8410/1/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/8410/1/be/src/runtime/coordinator.cc@1180 PS1, Line 1180: bloom_filter_.directory.clear(); > shrink_to_fit in the next line should free the memory. It's not enforced by It turns out string() has capacity 15 in GCC5.2 and 0 in GCC4.9. I think we should just track size() here since there is no guarantee on anything about capacity. I will abandon this. -- To view, visit http://gerrit.cloudera.org:8080/8410 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia28f9eb8d0b3e795d798949a1cfcfeaaec7040ed Gerrit-Change-Number: 8410 Gerrit-PatchSet: 1 Gerrit-Owner: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com> Gerrit-Comment-Date: Sat, 28 Oct 2017 05:06:44 +0000 Gerrit-HasComments: Yes
