Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/8412 )
Change subject: IMPALA-6126: ASAN detects heap-use-after-free in thrift-server-test ...................................................................... Patch Set 3: Looks like I found the real bug. The SASL library takes the string and holds a reference to it instead of copying it in sasl_server_init(). However, when we reinitialize the SASL library, it doesn't take in the new string because it detects that it was already previously initialized: https://github.com/cyrusimap/cyrus-sasl/blob/master/lib/server.c#L841 And we end up discarding the string that was held by it. So the fix is to get the string once and make sure it lives as long as the process does. -- To view, visit http://gerrit.cloudera.org:8080/8412 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2cd434757de2cd384def5b360a479e51812cccca Gerrit-Change-Number: 8412 Gerrit-PatchSet: 3 Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 31 Oct 2017 17:00:31 +0000 Gerrit-HasComments: No