Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/8430 )
Change subject: IMPALA-6136: Part 1: Query duration should not be normally negative. ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/8430/2/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/8430/2/be/src/service/impala-http-handler.cc@303 PS2, Line 303: // record.end_time_us might still be zero if the query is not yet done nit: Could you update the following comment in client-request-state.h and impala-server.h (once for ClientRequestState, once for QueryStateRecord) to say something about how 0 is a special value. /// Start/end time of the query, in Unix microseconds. int64_t start_time_us_, end_time_us_; -- To view, visit http://gerrit.cloudera.org:8080/8430 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib6f971ebd5f0f00f3e38df0495692ffe9d52ef90 Gerrit-Change-Number: 8430 Gerrit-PatchSet: 2 Gerrit-Owner: Zoram Thanga <zo...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Wed, 01 Nov 2017 16:02:19 +0000 Gerrit-HasComments: Yes
