Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/8305 )
Change subject: IMPALA-5599: Clean up references to TimestampValue in be/src. ...................................................................... Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/8305/11/be/src/service/client-request-state.h File be/src/service/client-request-state.h: http://gerrit.cloudera.org:8080/#/c/8305/11/be/src/service/client-request-state.h@342 PS11, Line 342: start_time_us_, end_time_us_; > These two may need to be initialized. https://gerrit.cloudera.org/#/c/8430/ http://gerrit.cloudera.org:8080/#/c/8305/11/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/8305/11/be/src/service/impala-http-handler.cc@303 PS11, Line 303: record.end_time_us - record.start_time_us; > This may be broken if end_time_us is not set yet. The old code will use the Fixing via https://gerrit.cloudera.org/#/c/8430/ http://gerrit.cloudera.org:8080/#/c/8305/11/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/8305/11/be/src/service/impala-server.h@622 PS11, Line 622: /// Start and end time of the query, in Unix microseconds. : int64_t start_time_us, end_time_us; > Can these be const ? They are always initialized in the constructor, right The default constructor does not handle this well if we make them constants. We'll have to make all/most of the other fields constant as well if we are going to fix this. -- To view, visit http://gerrit.cloudera.org:8080/8305 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I642a1d713597826bb7c15cd2ecb6638cb813a02c Gerrit-Change-Number: 8305 Gerrit-PatchSet: 11 Gerrit-Owner: Zoram Thanga <zo...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Wed, 01 Nov 2017 20:21:22 +0000 Gerrit-HasComments: Yes
