Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/8323 )
Change subject: IMPALA-1575: part 2: yield admission control resources ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/8323/5/be/src/runtime/coordinator.h File be/src/runtime/coordinator.h: http://gerrit.cloudera.org:8080/#/c/8323/5/be/src/runtime/coordinator.h@454 PS5, Line 454: probably released probably have been released http://gerrit.cloudera.org:8080/#/c/8323/5/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: http://gerrit.cloudera.org:8080/#/c/8323/5/be/src/runtime/coordinator.cc@831 PS5, Line 831: nit: here and elsewhere, we seem to have gratuitous blank lines which makes it harder to read code since you can't fit as much on a single screen. could you condense the places you've touched a bit? http://gerrit.cloudera.org:8080/#/c/8323/5/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/8323/5/tests/custom_cluster/test_admission_controller.py@91 PS5, Line 91: ] there is also session close and session timeout. but those should both result in close, so are we considering them covered by CLIENT_CLOSE? -- To view, visit http://gerrit.cloudera.org:8080/8323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I80279eb2bda740d7f61420f52db3bfa42a6a51ac Gerrit-Change-Number: 8323 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-Comment-Date: Mon, 06 Nov 2017 23:00:23 +0000 Gerrit-HasComments: Yes
