Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/8447 )
Change subject: IMPALA-2181: Add query option levels for display ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/8447/7/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/8447/7/shell/impala_shell.py@240 PS7, Line 240: if len(advanced_options) > 0 and print_mode == QueryOptionDisplayModes.ALL_OPTIONS: : print '\nAdvanced Query Options:' : self._print_option_group(advanced_options, set_options) : if len(deprecated_options) > 0 and print_mode == QueryOptionDisplayModes.ALL_OPTIONS: : print '\nDeprecated Query Options:' : self._print_option_group(deprecated_options, set_options) nit: this can be simplified as: if print_mode == QueryOptionDisplayModes.ALL_OPTIONS: if advanced_options: print '\nAdvanced Query Options:' self._print_option_group(advanced_options, set_options) if deprecated_options: print '\nDeprecated Query Options:' self._print_option_group(deprecated_options, set_options) -- To view, visit http://gerrit.cloudera.org:8080/8447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I75720d0d454527e1a0ed19bb43cf9e4f018ce1d1 Gerrit-Change-Number: 8447 Gerrit-PatchSet: 7 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 07 Nov 2017 15:01:23 +0000 Gerrit-HasComments: Yes
