Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/8490 )
Change subject: IMPALA-2248: Make idle_session_timeout a query option ...................................................................... Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/8490/3/be/src/service/client-request-state.cc File be/src/service/client-request-state.cc: http://gerrit.cloudera.org:8080/#/c/8490/3/be/src/service/client-request-state.cc@211 PS3, Line 211: } : else { single line http://gerrit.cloudera.org:8080/#/c/8490/3/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/8490/3/be/src/service/impala-server.h@403 PS3, Line 403: 'timeout' nit: formal parameter is 'requested_timeout' http://gerrit.cloudera.org:8080/#/c/8490/3/be/src/service/impala-server.cc File be/src/service/impala-server.cc: http://gerrit.cloudera.org:8080/#/c/8490/3/be/src/service/impala-server.cc@1119 PS3, Line 1119: if (session_timeout > 0) { : lock_guard<mutex> l(session_timeout_lock_); : multiset<int32_t>::const_iterator itr = session_timeout_set_.find(session_timeout); : DCHECK(itr != session_timeout_set_.end()); : session_timeout_set_.erase(itr); : session_timeout_cv_.notify_one(); : } Can we call UnregisterSessionTimeout() instead here? http://gerrit.cloudera.org:8080/#/c/8490/3/be/src/service/impala-server.cc@1236 PS3, Line 1236: nit: 4 character indents on line continuations http://gerrit.cloudera.org:8080/#/c/8490/3/fe/src/test/java/org/apache/impala/service/JdbcTest.java File fe/src/test/java/org/apache/impala/service/JdbcTest.java: http://gerrit.cloudera.org:8080/#/c/8490/3/fe/src/test/java/org/apache/impala/service/JdbcTest.java@657 PS3, Line 657: connections.get(0).close(); Maybe you can be more explicit here about the expected end-state, e.g.: assertNotNull("..", connections.get(0)); assertNull("..", connections.get(1)); assertNull("..", connections.get(2)); -- To view, visit http://gerrit.cloudera.org:8080/8490 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32e2775f80da387b0df4195fe2c5435b3f8e585e Gerrit-Change-Number: 8490 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 08 Nov 2017 12:37:19 +0000 Gerrit-HasComments: Yes
