Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/7793 )
Change subject: IMPALA-4252: Min-max runtime filters for Kudu ...................................................................... Patch Set 14: (7 comments) http://gerrit.cloudera.org:8080/#/c/7793/13/be/src/exec/kudu-scanner.cc File be/src/exec/kudu-scanner.cc: http://gerrit.cloudera.org:8080/#/c/7793/13/be/src/exec/kudu-scanner.cc@200 PS13, Line 200: if (!filter->GetCastIntMinMax(col_type, &int_min, &int_max)) { > Unfortunate that that every Kudu client has to do this. This is something that's been discussed before (see KUDU-931), I'm not sure why they decided not to do it. http://gerrit.cloudera.org:8080/#/c/7793/13/be/src/util/min-max-filter.cc File be/src/util/min-max-filter.cc: http://gerrit.cloudera.org:8080/#/c/7793/13/be/src/util/min-max-filter.cc@139 PS13, Line 139: case TYPE_BIGINT: > using std::numeric_limits; at the top if this file Done http://gerrit.cloudera.org:8080/#/c/7793/13/be/src/util/min-max-filter.cc@165 PS13, Line 165: > Brief comment especially about the return value would be good. Done http://gerrit.cloudera.org:8080/#/c/7793/13/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java File fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java: http://gerrit.cloudera.org:8080/#/c/7793/13/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@604 PS13, Line 604: // must be a SlotRef pointing to a column. We can allow implicit integer casts > typo: We can allow implicit integer casts Done http://gerrit.cloudera.org:8080/#/c/7793/13/fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java@605 PS13, Line 605: // by casting the min/max values before sending them to Kudu. > min/max values Done http://gerrit.cloudera.org:8080/#/c/7793/13/testdata/workloads/functional-query/queries/QueryTest/min_max_filters.test File testdata/workloads/functional-query/queries/QueryTest/min_max_filters.test: http://gerrit.cloudera.org:8080/#/c/7793/13/testdata/workloads/functional-query/queries/QueryTest/min_max_filters.test@98 PS13, Line 98: where a.tinyint_col = b.int_col and b.int_col in (0, 1) > Let's make the min/max filter selective, e.g. by adding where b.int_col in Done http://gerrit.cloudera.org:8080/#/c/7793/13/testdata/workloads/functional-query/queries/QueryTest/min_max_filters.test@103 PS13, Line 103: # The min/max values in the filter are both above the range of the target col so all rows > Let's also add a non-selective case where the min/max values fall outside t Done -- To view, visit http://gerrit.cloudera.org:8080/7793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I02bad890f5b5f78388a3041bf38f89369b5e2f1c Gerrit-Change-Number: 7793 Gerrit-PatchSet: 14 Gerrit-Owner: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Anonymous Coward #345 Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <mjac...@apache.org> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 09 Nov 2017 18:53:40 +0000 Gerrit-HasComments: Yes
