Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8498 )
Change subject: IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter ...................................................................... IMPALA-6164: Fix stale query profile in TestAlwaysFalseFilter TestAlwaysFalseFilter gets the query profile without fetching all the rows, resulting in a stale query profile and failing the test. With this patch all the rows are fetched before getting the query profile. This is enough to get the final profile because the query profile finalization is performed in Coordinator::GetNext after we hit eos. A bug in Base64Decode related to query profile decoding is also fixed. Currently Base64Decode may produce incorrect output length if the output parameter is not initialized with 0. Testing: TestAlwaysFalseFilter is run and passes 1000 times. It doesn't pass 1000 times consecutively without this patch. Change-Id: I04bb76d20541fa035d88167b593d1b8bc3873e89 Reviewed-on: http://gerrit.cloudera.org:8080/8498 Reviewed-by: Alex Behm <alex.b...@cloudera.com> Tested-by: Impala Public Jenkins --- M be/src/util/coding-util.cc M tests/custom_cluster/test_always_false_filter.py 2 files changed, 7 insertions(+), 2 deletions(-) Approvals: Alex Behm: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/8498 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I04bb76d20541fa035d88167b593d1b8bc3873e89 Gerrit-Change-Number: 8498 Gerrit-PatchSet: 5 Gerrit-Owner: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tianyi Wang <tw...@cloudera.com>
