Tim Wood has posted comments on this change. ( http://gerrit.cloudera.org:8080/8513 )
Change subject: IMPALA-6160: Allow multiple statements in a Query object. ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/8513/1/tests/performance/query_executor.py File tests/performance/query_executor.py: http://gerrit.cloudera.org:8080/#/c/8513/1/tests/performance/query_executor.py@52 PS1, Line 52: > I get that you consider SELECT as DML, but I don't think most other people Ack http://gerrit.cloudera.org:8080/#/c/8513/3/tests/performance/query_executor.py File tests/performance/query_executor.py: http://gerrit.cloudera.org:8080/#/c/8513/3/tests/performance/query_executor.py@190 PS3, Line 190: query (Query): SQL query (batch, ;-delimited) to be executed > This is still queries, not a single query, right? One or more; does the word "batch" not imply that? I'll put "query/queries". -- To view, visit http://gerrit.cloudera.org:8080/8513 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac86af181b7c42655f21d2c1efd4652dd35d9297 Gerrit-Change-Number: 8513 Gerrit-PatchSet: 3 Gerrit-Owner: Tim Wood <tw...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Matthew Mulder <mmul...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Tim Wood <tw...@cloudera.com> Gerrit-Comment-Date: Mon, 13 Nov 2017 21:12:40 +0000 Gerrit-HasComments: Yes
