Kim Jin Chul has posted comments on this change. ( http://gerrit.cloudera.org:8080/8355 )
Change subject: IMPALA-5754: Improve randomness of rand()/random() ...................................................................... Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/8355/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/8355/8//COMMIT_MSG@11 PS8, Line 11: library > typo: library Done http://gerrit.cloudera.org:8080/#/c/8355/8/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/8355/8/be/src/exprs/expr-test.cc@4660 PS8, Line 4660: const double expected_result = ConvertValue<double>(GetValue(rand.str(), TYPE_DOUBLE)); > nit: Please wrap lines at 90 characters. Done http://gerrit.cloudera.org:8080/#/c/8355/6/be/src/exprs/math-functions-ir.cc File be/src/exprs/math-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/8355/6/be/src/exprs/math-functions-ir.cc@179 PS6, Line 179: } > I'm not confident that works nicely with boost::thread and pthreads. I emai Okay, I support your suggestion. http://gerrit.cloudera.org:8080/#/c/8355/8/be/src/exprs/math-functions-ir.cc File be/src/exprs/math-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/8355/8/be/src/exprs/math-functions-ir.cc@163 PS8, Line 163: if (!seed_arg->is_null) seed = seed_arg->val; : } : mt1 > nit: one line. Also, please remove the space after ! Done -- To view, visit http://gerrit.cloudera.org:8080/8355 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idafdd5fe7502ff242c76a91a815c565146108684 Gerrit-Change-Number: 8355 Gerrit-PatchSet: 11 Gerrit-Owner: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Attila Jeges <atti...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbapple-imp...@apache.org> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Comment-Date: Tue, 14 Nov 2017 22:26:55 +0000 Gerrit-HasComments: Yes
