qiaojialin commented on a change in pull request #756: add new byTimestampReader URL: https://github.com/apache/incubator-iotdb/pull/756#discussion_r368984484
########## File path: server/src/main/java/org/apache/iotdb/db/query/reader/resourceRelated/SeqResourceReaderByTimestamp.java ########## @@ -1,190 +1,189 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, - * software distributed under the License is distributed on an - * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY - * KIND, either express or implied. See the License for the - * specific language governing permissions and limitations - * under the License. - */ -package org.apache.iotdb.db.query.reader.resourceRelated; - -import java.io.IOException; -import java.util.List; -import org.apache.iotdb.db.engine.cache.DeviceMetaDataCache; -import org.apache.iotdb.db.engine.modification.Modification; -import org.apache.iotdb.db.engine.storagegroup.TsFileResource; -import org.apache.iotdb.db.query.context.QueryContext; -import org.apache.iotdb.db.query.control.FileReaderManager; -import org.apache.iotdb.db.query.reader.IReaderByTimestamp; -import org.apache.iotdb.db.query.reader.fileRelated.FileSeriesReaderByTimestampAdapter; -import org.apache.iotdb.db.query.reader.fileRelated.UnSealedTsFileReaderByTimestamp; -import org.apache.iotdb.db.utils.QueryUtils; -import org.apache.iotdb.tsfile.file.metadata.ChunkMetaData; -import org.apache.iotdb.tsfile.read.TsFileSequenceReader; -import org.apache.iotdb.tsfile.read.common.Path; -import org.apache.iotdb.tsfile.read.controller.IChunkLoader; -import org.apache.iotdb.tsfile.read.controller.ChunkLoaderImpl; -import org.apache.iotdb.tsfile.read.reader.series.FileSeriesReaderByTimestamp; - -/** - * To read a chronologically ordered list of sequence TsFiles by timestamp, this class implements - * <code>IReaderByTimestamp</code> for the TsFiles. - * <p> - * Notes: 1) The list of sequence TsFiles is in strict chronological order. 2) The data in a - * sequence TsFile is also organized in chronological order. 3) A sequence TsFile can be either - * sealed or unsealed. 4) An unsealed sequence TsFile consists of two parts of data in chronological - * order: data that has been flushed to disk and data in the flushing memtable list. - * <p> - * This class is used in {@link org.apache.iotdb.db.query.reader.seriesRelated.SeriesReaderByTimestamp}. - */ - -public class SeqResourceReaderByTimestamp implements IReaderByTimestamp { - - protected Path seriesPath; - private List<TsFileResource> seqResources; - private QueryContext context; - private int nextIntervalFileIndex; - private IReaderByTimestamp seriesReader; - - /** - * Constructor function. - * <p> - * - * @param seriesPath the path of the series data - * @param seqResources a list of sequence TsFile resources in chronological order - * @param context query context - */ - public SeqResourceReaderByTimestamp(Path seriesPath, List<TsFileResource> seqResources, - QueryContext context) { - this.seriesPath = seriesPath; - this.seqResources = seqResources; - this.context = context; - this.nextIntervalFileIndex = 0; - this.seriesReader = null; - } - - @Override - public Object getValueInTimestamp(long timestamp) throws IOException { - Object value = null; - - if (seriesReader != null) { - value = seriesReader.getValueInTimestamp(timestamp); - // if get value or no value in this timestamp but has next, return. - if (value != null || seriesReader.hasNext()) { - return value; - } - } - - // Because the sequence TsFile resources are chronologically globally ordered, there exists at - // most one TsFile resource that overlaps this timestamp. - while (nextIntervalFileIndex < seqResources.size()) { - boolean isConstructed = constructNextReader(nextIntervalFileIndex++, timestamp); - if (isConstructed) { - value = seriesReader.getValueInTimestamp(timestamp); - // if get value or no value in this timestamp but has next, return. - if (value != null || seriesReader.hasNext()) { - return value; - } - } - } - return value; - } - - @Override - public boolean hasNext() throws IOException { - if (seriesReader != null && seriesReader.hasNext()) { - return true; - } - - while (nextIntervalFileIndex < seqResources.size()) { - TsFileResource tsFileResource = seqResources.get(nextIntervalFileIndex++); - if (tsFileResource.isClosed()) { - seriesReader = initSealedTsFileReaderByTimestamp(tsFileResource, context); - } else { - seriesReader = new UnSealedTsFileReaderByTimestamp(tsFileResource); - } - if (seriesReader.hasNext()) { - return true; - } - } - return false; - } - - /** - * If the idx-th TsFile in the <code>seqResources</code> might overlap this - * <code>timestamp</code>, then construct <code>IReaderByTimestamp</code> for it, assign to the - * <code>currentSeriesReader</code> and return true. Otherwise, return false. - * <p> - * Note that the list of sequence TsFiles is chronologically ordered, so there will be at most one - * TsFile that overlaps this timestamp. - * - * @param idx the index of the TsFile in the resource list - * @param timestamp check whether or not to construct the reader according to this timestamp - * @return True if the reader is constructed; False if not. - */ - private boolean constructNextReader(int idx, long timestamp) throws IOException { - TsFileResource tsFileResource = seqResources.get(idx); - if (tsFileResource.isClosed()) { - if (isTsFileNotSatisfied(tsFileResource, timestamp)) { - return false; - } - seriesReader = initSealedTsFileReaderByTimestamp(tsFileResource, context); - return true; - } else { - // an unsealed sequence TsFile's endTimeMap size may be equal to 0 or greater than 0 - // If endTimeMap size is 0, conservatively assume that this TsFile might overlap this timestamp. - // If endTimeMap size is not 0, call isTsFileNotSatisfied to check. - if (tsFileResource.getEndTimeMap().size() != 0) { - if (isTsFileNotSatisfied(tsFileResource, timestamp)) { - return false; - } - } - seriesReader = new UnSealedTsFileReaderByTimestamp(tsFileResource); - return true; - } - } - - /** - * Returns true if the end time of the series data in this sequence TsFile is smaller than this - * timestamp. - * <p> - * Note that <code>seqResources</code> is a list of chronologically ordered sequence TsFiles, so - * there will be at most one TsFile that overlaps this timestamp. - * <p> - * This method is used to in <code>constructNextReader</code> to check whether this TsFile can be - * skipped. - */ - private boolean isTsFileNotSatisfied(TsFileResource tsFile, long timestamp) { - return tsFile.getEndTimeMap().get(seriesPath.getDevice()) < timestamp; - } - - private IReaderByTimestamp initSealedTsFileReaderByTimestamp(TsFileResource sealedTsFile, - QueryContext context) throws IOException { - // prepare metaDataList - List<ChunkMetaData> metaDataList = DeviceMetaDataCache.getInstance() - .get(sealedTsFile, seriesPath); - - List<Modification> pathModifications = context.getPathModifications(sealedTsFile.getModFile(), - seriesPath.getFullPath()); - if (!pathModifications.isEmpty()) { - QueryUtils.modifyChunkMetaData(metaDataList, pathModifications); - } - // prepare chunkLoader - TsFileSequenceReader tsFileReader = FileReaderManager.getInstance() - .get(sealedTsFile, true); - IChunkLoader chunkLoader = new ChunkLoaderImpl(tsFileReader); - - return new FileSeriesReaderByTimestampAdapter( - new FileSeriesReaderByTimestamp(chunkLoader, metaDataList)); - } -} \ No newline at end of file +///* +// * Licensed to the Apache Software Foundation (ASF) under one +// * or more contributor license agreements. See the NOTICE file +// * distributed with this work for additional information +// * regarding copyright ownership. The ASF licenses this file +// * to you under the Apache License, Version 2.0 (the +// * "License"); you may not use this file except in compliance +// * with the License. You may obtain a copy of the License at +// * +// * http://www.apache.org/licenses/LICENSE-2.0 +// * +// * Unless required by applicable law or agreed to in writing, +// * software distributed under the License is distributed on an +// * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// * KIND, either express or implied. See the License for the +// * specific language governing permissions and limitations +// * under the License. +// */ +//package org.apache.iotdb.db.query.reader.resourceRelated; +// +//import java.io.IOException; +//import java.util.List; +//import org.apache.iotdb.db.engine.cache.DeviceMetaDataCache; +//import org.apache.iotdb.db.engine.modification.Modification; +//import org.apache.iotdb.db.engine.storagegroup.TsFileResource; +//import org.apache.iotdb.db.query.context.QueryContext; +//import org.apache.iotdb.db.query.control.FileReaderManager; +//import org.apache.iotdb.db.query.reader.IReaderByTimestamp; +//import org.apache.iotdb.db.query.reader.fileRelated.FileSeriesReaderByTimestampAdapter; +//import org.apache.iotdb.db.query.reader.fileRelated.UnSealedTsFileReaderByTimestamp; +//import org.apache.iotdb.db.utils.QueryUtils; +//import org.apache.iotdb.tsfile.file.metadata.ChunkMetaData; +//import org.apache.iotdb.tsfile.read.TsFileSequenceReader; +//import org.apache.iotdb.tsfile.read.common.Path; +//import org.apache.iotdb.tsfile.read.controller.IChunkLoader; +//import org.apache.iotdb.tsfile.read.controller.ChunkLoaderImpl; +//import org.apache.iotdb.tsfile.read.reader.series.FileSeriesReaderByTimestamp; +// +///** +// * To read a chronologically ordered list of sequence TsFiles by timestamp, this class implements +// * <code>IReaderByTimestamp</code> for the TsFiles. +// * <p> +// * Notes: 1) The list of sequence TsFiles is in strict chronological order. 2) The data in a +// * sequence TsFile is also organized in chronological order. 3) A sequence TsFile can be either +// * sealed or unsealed. 4) An unsealed sequence TsFile consists of two parts of data in chronological +// * order: data that has been flushed to disk and data in the flushing memtable list. +// * <p> +// */ +// +//public class SeqResourceReaderByTimestamp implements IReaderByTimestamp { Review comment: remove this class ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
