qiaojialin commented on a change in pull request #769: [IOTDB-452] Do all aggregations of one series at one pass in GroupBy URL: https://github.com/apache/incubator-iotdb/pull/769#discussion_r375091649
########## File path: server/src/main/java/org/apache/iotdb/db/query/dataset/groupby/GroupByWithoutValueFilterDataSet.java ########## @@ -43,7 +46,17 @@ public class GroupByWithoutValueFilterDataSet extends GroupByEngineDataSet { - private List<IAggregateReader> seriesReaders; + /** + * Merges same series to one map. For example: Given: paths: s1, s2, s3, s1 and aggregations: + * count, sum, count, sum seriesMap: s1 -> 0, 3; s2 -> 2; s3 -> 3 + */ + private Map<Path, List<Integer>> seriesReaders; Review comment: ```suggestion private Map<Path, List<Integer>> pathToAggrIndexes; ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services