samperson1997 commented on pull request #1204: URL: https://github.com/apache/incubator-iotdb/pull/1204#issuecomment-630549771
> We could add the group by level=n to AggregationPlan, not the GroupByPlan. > > The group by plan segment the query interval [1,10) to many 2ms ranges and do aggregation in each range. Add a level=1 may have confusion. > e.g., select count(s1) from root.turbine1.d1 group by ([1,10),2ms), level=1 Actually I think maybe we should define a new type of plan, which extends AggregationPlan? From my point of view, a new plan would be better instead of just using a field to classify, and the code would be more clear ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
