qiaojialin commented on a change in pull request #1693:
URL: https://github.com/apache/incubator-iotdb/pull/1693#discussion_r486802944
##########
File path:
server/src/test/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessorTest.java
##########
@@ -273,6 +274,112 @@ public void testSeqAndUnSeqSyncClose()
}
}
+ @Test
+ public void testEnableDiscardOutOfOrderDataForInsertRowPlan()
+ throws WriteProcessException, QueryProcessException,
IllegalPathException {
+ IoTDBConfig config = IoTDBDescriptor.getInstance().getConfig();
+ config.setEnableDiscardOutOfOrderData(true);
Review comment:
remember to reset this to its default value in the end of the test
We usually do this as follows:
boolean defaultValue = config.isEnableDiscard...;
config.setEnableDiscard(true);
do some test
config.setEnableDiscard(defaultValue);
##########
File path:
server/src/test/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessorTest.java
##########
@@ -273,6 +274,112 @@ public void testSeqAndUnSeqSyncClose()
}
}
+ @Test
+ public void testEnableDiscardOutOfOrderDataForInsertRowPlan()
+ throws WriteProcessException, QueryProcessException,
IllegalPathException {
+ IoTDBConfig config = IoTDBDescriptor.getInstance().getConfig();
+ config.setEnableDiscardOutOfOrderData(true);
Review comment:
remember to reset this to its default value in the end of the test
We usually do this as follows:
boolean defaultValue = config.isEnableDiscard...;
config.setEnableDiscard(true);
do some test
config.setEnableDiscard(defaultValue);
##########
File path:
server/src/test/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessorTest.java
##########
@@ -273,6 +274,112 @@ public void testSeqAndUnSeqSyncClose()
}
}
+ @Test
+ public void testEnableDiscardOutOfOrderDataForInsertRowPlan()
+ throws WriteProcessException, QueryProcessException,
IllegalPathException {
+ IoTDBConfig config = IoTDBDescriptor.getInstance().getConfig();
+ config.setEnableDiscardOutOfOrderData(true);
Review comment:
remember to reset this to its default value in the end of the test
We usually do this as follows:
boolean defaultValue = config.isEnableDiscard...;
config.setEnableDiscard(true);
do some test
config.setEnableDiscard(defaultValue);
##########
File path:
server/src/test/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessorTest.java
##########
@@ -273,6 +274,112 @@ public void testSeqAndUnSeqSyncClose()
}
}
+ @Test
+ public void testEnableDiscardOutOfOrderDataForInsertRowPlan()
+ throws WriteProcessException, QueryProcessException,
IllegalPathException {
+ IoTDBConfig config = IoTDBDescriptor.getInstance().getConfig();
+ config.setEnableDiscardOutOfOrderData(true);
Review comment:
remember to reset this to its default value in the end of the test
We usually do this as follows:
boolean defaultValue = config.isEnableDiscard...;
config.setEnableDiscard(true);
do some test
config.setEnableDiscard(defaultValue);
##########
File path:
server/src/test/java/org/apache/iotdb/db/engine/storagegroup/StorageGroupProcessorTest.java
##########
@@ -273,6 +274,112 @@ public void testSeqAndUnSeqSyncClose()
}
}
+ @Test
+ public void testEnableDiscardOutOfOrderDataForInsertRowPlan()
+ throws WriteProcessException, QueryProcessException,
IllegalPathException {
+ IoTDBConfig config = IoTDBDescriptor.getInstance().getConfig();
+ config.setEnableDiscardOutOfOrderData(true);
Review comment:
remember to reset this to its default value in the end of the test
We usually do this as follows:
boolean defaultValue = config.isEnableDiscard...;
config.setEnableDiscard(true);
do some test
config.setEnableDiscard(defaultValue);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
