[GitHub] [incubator-iotdb] qiaojialin commented on a change in pull request #1750: [Sonar] Fix Codesmell blocker and critical issue

[GitBox]

qiaojialin commented on a change in pull request #1750:
URL: https://github.com/apache/incubator-iotdb/pull/1750#discussion_r493266292



##########
File path: 
hive-connector/src/main/java/org/apache/iotdb/hive/TsFileDeserializer.java
##########
@@ -34,7 +34,8 @@
 
 public class TsFileDeserializer {
   private static final Logger LOG = 
LoggerFactory.getLogger(TsFileDeserializer.class);
-
+  private static final String UNEXPECTED_DATA_TYPE = "Unexpected data type: ";
+  private static final String FOR_DATE_TYPEINFO = " for Date TypeInfo: ";

Review comment:
       combine these two

##########
File path: 
server/src/main/java/org/apache/iotdb/db/qp/strategy/LogicalGenerator.java
##########
@@ -200,6 +200,9 @@
   private UpdateOperator updateOp;
   private QueryOperator queryOp;
   private DeleteDataOperator deleteDataOp;
+  private static final String FOR_DELETE_STATEMENT = "For delete statement, 
where clause can only contain atomic expressions like : ";
+  private static final String ATOMIC_EXPRESSION_RULE = "time > XXX, time <= 
XXX, or two atomic expressions connected by 'AND'";

Review comment:
       combine to one string




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org