yuqi1129 commented on pull request #1786: URL: https://github.com/apache/incubator-iotdb/pull/1786#issuecomment-701249403
OK, force-push is indeed not suggested in PR. The reason why i try to overlap the code before is that i do not want to have too many commit message. Till now, Git can squash commits into one, so i do not need to use force push again, Thanks Xiangwei Wei <notificati...@github.com> 于2020年9月30日周三 下午4:23写道： > *@Alima777* approved this pull request. > > Nice work~ One suggestion is that force-push every time is not a good way > especially in a big patch... as we can not see the changes of each commit. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/incubator-iotdb/pull/1786#pullrequestreview-499193914>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ADYQDBAEOGPDF7CN2A6LDNDSILTJLANCNFSM4R6TA63Q> > . > ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
