JackieTien97 commented on code in PR #8666:
URL: https://github.com/apache/iotdb/pull/8666#discussion_r1060233868
##########
thrift/src/main/thrift/client.thrift:
##########
@@ -545,6 +560,8 @@ service IClientRPCService {
TSExecuteStatementResp executeLastDataQuery(1:TSLastDataQueryReq req);
+ TSExecuteStatementResp executeAggregationQuery(1:TSAggregationQueryReq req);
+
Review Comment:
we never need this, because old version session won't see this new interface.
##########
isession/src/main/java/org/apache/iotdb/isession/util/Aggregation.java:
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iotdb.isession.util;
+
+public enum Aggregation {
Review Comment:
Make it a thrift enum class, and delete `AggregationType` in server and
instead use the new enum, we should unify the usage of this enum.
In this way, all other languages can use `Aggregation` enum.
##########
thrift/src/main/thrift/client.thrift:
##########
@@ -331,11 +331,24 @@ struct TSLastDataQueryReq {
3: optional i32 fetchSize
4: required i64 time
5: required i64 statementId
- 6: optional bool enableRedirectQuery;
- 7: optional bool jdbcQuery;
+ 6: optional bool enableRedirectQuery
+ 7: optional bool jdbcQuery
8: optional i64 timeout
}
+struct TSAggregationQueryReq {
+ 1: required i64 sessionId
+ 2: required i64 statementId
+ 3: required list<string> paths
+ 4: required list<string> aggregations
Review Comment:
use thrift-defined enum instead of string
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
