ericpai commented on code in PR #8708: URL: https://github.com/apache/iotdb/pull/8708#discussion_r1060271229
########## server/src/assembly/resources/conf/iotdb-datanode.properties: ########## @@ -17,6 +17,14 @@ # under the License. # +#################### +### Cluster Configuration +#################### + +# Used for indicate cluster name and distinguish different cluster. +# Datatype: string +cluster_name=defaultCluster Review Comment: Both iotdb-datanode.properties and iotdb-confignode.properties have this parameter, which violates our [design](https://apache-iotdb.feishu.cn/docx/doxcnjzB2xd9sScIlkNYJUJA1zb) about the configuration files. Move it to iotdb-common.properties instead. ########## confignode/src/assembly/resources/conf/iotdb-confignode.properties: ########## @@ -17,6 +17,14 @@ # under the License. # +#################### +### Cluster Configuration +#################### + +# Used for indicate cluster name and distinguish different cluster. +# Datatype: string +cluster_name=defaultCluster Review Comment: All the keys in iotdb-confignode.properties have `cn_` prefix. It's better to change `cluster_name` to `cn_cluster_name`, or just move it to iotdb-commom.properties ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
