[GitHub] [iotdb] ycycse commented on a diff in pull request #10507: [IoTDB ML] Basic model training and inference features available

[via GitHub]

ycycse commented on code in PR #10507:
URL: https://github.com/apache/iotdb/pull/10507#discussion_r1309835948


##########
iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ModelManager.java:
##########
@@ -63,15 +81,41 @@ public ModelInfo getModelInfo() {
   }
 
   public TSStatus createModel(TCreateModelReq req) {
-    ModelInformation modelInformation =
-        new ModelInformation(
-            req.getModelId(),
-            req.getModelTask(),
-            req.getModelType(),
-            req.isIsAuto(),
-            req.getQueryExpressions(),
-            req.getQueryFilter());
-    return configManager.getProcedureManager().createModel(modelInformation, 
req.getModelConfigs());
+    TaskType taskType = req.getTaskType();
+
+    Map<String, String> options = req.getOptions();
+    ModelInformation modelInformation;
+    if (taskType == TaskType.FORECAST) {
+      String inputTypeListStr = options.get(INPUT_TYPE_LIST);
+      List<TSDataType> inputTypeList =
+          Arrays.stream(inputTypeListStr.substring(1, 
inputTypeListStr.length() - 1).split(","))
+              .sequential()

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org