MarcosZyk commented on code in PR #11736: URL: https://github.com/apache/iotdb/pull/11736#discussion_r1430844425
########## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/mtree/impl/pbtree/memory/buffer/NodeBuffer.java: ########## @@ -0,0 +1,224 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iotdb.db.schemaengine.schemaregion.mtree.impl.pbtree.memory.buffer; + +import org.apache.iotdb.commons.schema.node.role.IDatabaseMNode; +import org.apache.iotdb.db.schemaengine.schemaregion.mtree.impl.pbtree.memory.cache.CacheEntry; +import org.apache.iotdb.db.schemaengine.schemaregion.mtree.impl.pbtree.mnode.ICachedMNode; + +import java.util.Iterator; +import java.util.Map; +import java.util.NoSuchElementException; +import java.util.concurrent.ConcurrentHashMap; + +/** + * The ancestors of the volatile nodes. If a node is not volatile but not in nodeCache, it means + * this node is an ancestor of some volatile node. Any volatile node is contained in the + * CachedContainer of its parent. The parent will be placed in nodeBuffer. If the parent is volatile + * as well, then the parent of the parent will be hold nodeBuffer instead, which means the root node + * of a maximum volatile subtree will be placed in node buffer. + */ +public class NodeBuffer implements INodeBuffer { + + private static final int MAP_NUM = 17; + + private IDatabaseMNode<ICachedMNode> updatedDatabaseMNode; + private final Map<CacheEntry, ICachedMNode>[] maps = new Map[MAP_NUM]; + + private final Map<Integer, NodeBufferIterator> currentIteratorMap = new ConcurrentHashMap<>(); Review Comment: May cause memory leak since there's no specific release or close logic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
