CritasWang commented on code in PR #11788: URL: https://github.com/apache/iotdb/pull/11788#discussion_r1436376022
########## iotdb-core/node-commons/src/assembly/resources/conf/iotdb-cluster.properties: ########## @@ -0,0 +1,34 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + + +# this function is for parsing the variables like "A=B" in `start-server.sh -D A=B` +# The command just parse IOTDB-prefixed variables and ignore all other variables + +# Configure ConfigNodes machine addresses separated by , +confignode_address_list=127.0.0.1 Review Comment: Default comment out ########## iotdb-core/node-commons/src/assembly/resources/sbin/start-all.sh: ########## @@ -0,0 +1,69 @@ +#!/bin/bash +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +if [ -z "${IOTDB_HOME}" ]; then + export IOTDB_HOME="`dirname "$0"`/.." +fi +# iotdb-cluster.properties does not exist, the current 1C1D is started +if [ ! -f ${IOTDB_HOME}/conf/iotdb-cluster.properties ]; then + exec ${IOTDB_HOME}/sbin/start-standalone.sh +else + confignodeStr=$(sed '/^confignode_address_list=/!d;s/.*=//' "${IOTDB_HOME}"/conf/iotdb-cluster.properties) Review Comment: This repeated paragraph should be extracted as a common script -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
