OneSizeFitsQuorum commented on code in PR #11885:
URL: https://github.com/apache/iotdb/pull/11885#discussion_r1468811565
##########
iotdb-client/cli/src/main/java/org/apache/iotdb/cli/IoTDBSyntaxHighlighter.java:
##########
@@ -67,12 +67,14 @@ public AttributedString highlight(LineReader reader, String
buffer) {
@Override
public void setErrorPattern(Pattern errorPattern) {
- IoTPrinter.print("");
+ // TODO: Not quite sure what this code should actually do
+ new IoTPrinter(System.out).print("");
}
@Override
public void setErrorIndex(int errorIndex) {
- IoTPrinter.print("");
+ // TODO: Not quite sure what this code should actually do
Review Comment:
same as above
##########
iotdb-client/cli/src/main/java/org/apache/iotdb/cli/IoTDBSyntaxHighlighter.java:
##########
@@ -67,12 +67,14 @@ public AttributedString highlight(LineReader reader, String
buffer) {
@Override
public void setErrorPattern(Pattern errorPattern) {
- IoTPrinter.print("");
+ // TODO: Not quite sure what this code should actually do
Review Comment:
This class was temporarily disabled in
[PR](https://github.com/apache/iotdb/blob/master/iotdb-client/cli/src/main/java/org/apache/iotdb/cli/utils/JlineUtils.java#L90).
Perhaps we can remove this class, or leave it at that? Adding these comments
does not seem to help
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/DataNode.java:
##########
@@ -917,6 +925,9 @@ public void stop() {
if (dataRegionConsensusStarted) {
DataRegionConsensusImpl.getInstance().stop();
}
+ /*if
(IoTDBRestServiceDescriptor.getInstance().getConfig().isEnableRestService()) {
Review Comment:
seems we can remove this line? or just put this uncommented line to
`deactivate()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
