shuwenwei commented on code in PR #12122:
URL: https://github.com/apache/iotdb/pull/12122#discussion_r1565451572
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/schedule/CompactionScheduleTaskManager.java:
##########
Review Comment:
If a repair data task started, all thread in
compactionScheduleTaskThreadPool will be used to scan tsfiles. The actual num
of repair data scan file threads will be `compactionSelectorNum` +
`ttlCheckerNum`.
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/rescon/memory/SystemInfo.java:
##########
Review Comment:
Method `addCompactionMemoryCost(
CompactionTaskType taskType, long memoryCost, boolean
waitUntilAcquired)` is no longer used after a past change.
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/schedule/CompactionScheduler.java:
##########
@@ -100,11 +102,19 @@ public static int scheduleCompaction(
// the name of this variable is trySubmitCount, because the task submitted
to the queue could be
// evicted due to the low priority of the task
int trySubmitCount = 0;
- trySubmitCount += tryToSubmitCrossSpaceCompactionTask(tsFileManager,
timePartition, summary);
- trySubmitCount +=
- tryToSubmitInnerSpaceCompactionTask(tsFileManager, timePartition,
true, summary);
- trySubmitCount +=
- tryToSubmitInnerSpaceCompactionTask(tsFileManager, timePartition,
false, summary);
+ try {
+ trySubmitCount += tryToSubmitCrossSpaceCompactionTask(tsFileManager,
timePartition, summary);
+ trySubmitCount +=
+ tryToSubmitInnerSpaceCompactionTask(tsFileManager, timePartition,
true, summary);
+ trySubmitCount +=
+ tryToSubmitInnerSpaceCompactionTask(tsFileManager, timePartition,
false, summary);
+ trySubmitCount +=
+ tryToSubmitSettleCompactionTask(tsFileManager, timePartition,
summary, false);
+ } catch (InterruptedException e) {
Review Comment:
Should `tryToSubmitSettleCompactionTask` be executed first? After the
previous selections, many resources has been marked as COMPACTION_CANDIDATE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
