CRZbulabula commented on code in PR #12342: URL: https://github.com/apache/iotdb/pull/12342#discussion_r1568441311
########## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/region/AddRegionPeerProcedure.java: ########## @@ -92,6 +94,7 @@ protected Flow executeFromState(ConfigNodeProcedureEnv env, AddRegionPeerState s setNextState(AddRegionPeerState.DO_ADD_REGION_PEER); break; case DO_ADD_REGION_PEER: + handler.updateRegionCache(consensusGroupId, destDataNode, RegionStatus.Adding); Review Comment: Why should update RegionStatus to Adding twice? ########## iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/procedure/impl/region/RemoveRegionPeerProcedure.java: ########## @@ -100,6 +102,7 @@ protected Flow executeFromState(ConfigNodeProcedureEnv env, RemoveRegionPeerStat setNextState(DELETE_OLD_REGION_PEER); break; case DELETE_OLD_REGION_PEER: + handler.updateRegionCache(consensusGroupId, targetDataNode, RegionStatus.Removing); Review Comment: Why should update RegionStatus to Removing twice? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org