JackieTien97 commented on code in PR #12393:
URL: https://github.com/apache/iotdb/pull/12393#discussion_r1577089745
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/plan/node/PlanNodeType.java:
##########
@@ -209,6 +209,8 @@ public enum PlanNodeType {
EXPLAIN_ANALYZE((short) 90),
PIPE_OPERATE_SCHEMA_QUEUE_REFERENCE((short) 91),
+
+ FULL_OUTER_TIME_JOIN_REFERENCE((short) 92),
Review Comment:
what's this for?
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/LocalExecutionPlanContext.java:
##########
@@ -91,6 +98,10 @@ public class LocalExecutionPlanContext {
// use AtomicReference not for thread-safe, just for updating same field in
different pipeline
private AtomicReference<List<Long>> timePartitions = new AtomicReference<>();
+ /** Records the parent of each pipeline. The order of each list does not
matter for now. */
+ private Map<PlanNodeId, List<PipelineMemoryEstimator>>
parentPlanNodeIdToMemoryEstimator =
Review Comment:
remember to set this map to null, after you check the memory, this Map may
occupy huge memory when there are many devices;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
