choubenson commented on code in PR #12122: URL: https://github.com/apache/iotdb/pull/12122#discussion_r1577350238
########## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/compaction/execute/task/InnerSpaceCompactionTask.java: ########## @@ -483,6 +476,13 @@ private void releaseAllLocks() { @Override public long getEstimatedMemoryCost() { + if (innerSpaceEstimator == null) { + if (this.performer instanceof ReadChunkCompactionPerformer) { + innerSpaceEstimator = new ReadChunkInnerCompactionEstimator(); + } else if (this.performer instanceof FastCompactionPerformer) { + innerSpaceEstimator = new FastCompactionInnerCompactionEstimator(); + } Review Comment: Because the estimator is not simply determined by the `performer`, but also depends on the compaction `task type`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org