JackieTien97 commented on code in PR #12447:
URL: https://github.com/apache/iotdb/pull/12447#discussion_r1584515815
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/tag/TagManager.java:
##########
@@ -212,20 +209,18 @@ public void removeIndex(String tagKey, String tagValue,
IMeasurementMNode<?> mea
// init memory size
int memorySize = 0;
Review Comment:
make it as long
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/tag/TagManager.java:
##########
@@ -181,18 +180,16 @@ public void addIndex(String tagKey, String tagValue,
IMeasurementMNode<?> measur
int memorySize = 0;
Review Comment:
make it as long
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/schemaengine/schemaregion/tag/TagLogFile.java:
##########
@@ -129,14 +129,12 @@ public static ByteBuffer parseByteBuffer(FileChannel
fileChannel, long position)
ByteBuffer byteBuffers = ByteBuffer.allocate(blockNum * MAX_LENGTH);
byteBuffers.put(byteBuffer);
byteBuffers.position(4); // Skip blockNum
- List<Long> blockOffset = new ArrayList<>();
- blockOffset.add(position);
for (int i = 1; i < blockNum; i++) {
- blockOffset.add(ReadWriteIOUtils.readLong(byteBuffers));
+ Long nextPosition = ReadWriteIOUtils.readLong(byteBuffers);
Review Comment:
```suggestion
long nextPosition = ReadWriteIOUtils.readLong(byteBuffers);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
