CritasWang commented on code in PR #12454:
URL: https://github.com/apache/iotdb/pull/12454#discussion_r1591910947
##########
iotdb-client/cli/src/assembly/resources/conf/logback-cli.xml:
##########
@@ -26,7 +26,24 @@
<level>ERROR</level>
</filter>
</appender>
- <root level="error">
+ <appender class="ch.qos.logback.core.rolling.RollingFileAppender"
name="backup">
Review Comment:
This file will not be included in the current packaging. If it is written
here, need to modify maven assembly config
##########
iotdb-client/cli/src/assembly/resources/conf/logback-cli.xml:
##########
@@ -26,7 +26,24 @@
<level>ERROR</level>
</filter>
</appender>
- <root level="error">
+ <appender class="ch.qos.logback.core.rolling.RollingFileAppender"
name="backup">
+ <Encoding>UTF-8</Encoding>
+ <file>${IOTDB_HOME}/logs/log-iotdb-data-back.log</file>
Review Comment:
log_backup.log
##########
iotdb-client/cli/src/assembly/resources/conf/logback-cli.xml:
##########
@@ -26,7 +26,24 @@
<level>ERROR</level>
</filter>
</appender>
- <root level="error">
+ <appender class="ch.qos.logback.core.rolling.RollingFileAppender"
name="backup">
+ <Encoding>UTF-8</Encoding>
+ <file>${IOTDB_HOME}/logs/log-iotdb-data-back.log</file>
+ <rollingPolicy
class="ch.qos.logback.core.rolling.TimeBasedRollingPolicy">
+
<fileNamePattern>${IOTDB_HOME}/logs/log-iotdb-data-back-%d{yyyyMMdd}.log.gz</fileNamePattern>
Review Comment:
log-backup-%d{yyyyMMdd}.log.gz.log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
