OneSizeFitsQuorum commented on code in PR #12463:
URL: https://github.com/apache/iotdb/pull/12463#discussion_r1599683539
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/thrift/impl/DataNodeInternalRPCServiceImpl.java:
##########
@@ -2157,7 +2157,9 @@ private TSStatus createNewRegionPeer(ConsensusGroupId
regionId, List<Peer> peers
if (regionId instanceof DataRegionId) {
DataRegionConsensusImpl.getInstance().createLocalPeer(regionId, peers);
} else {
- SchemaRegionConsensusImpl.getInstance().createLocalPeer(regionId,
peers);
+ final List<Peer> createParam =
Review Comment:
I recommend not adding the isRatis function here, but instead just checking
the consensus algorithm to see if an empty list should be passed in
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
