SteveYurongSu commented on code in PR #12326:
URL: https://github.com/apache/iotdb/pull/12326#discussion_r1611471054
##########
iotdb-client/service-rpc/src/main/java/org/apache/iotdb/rpc/subscription/exception/SubscriptionConnectionException.java:
##########
@@ -21,25 +21,20 @@
import java.util.Objects;
-public class SubscriptionPollTimeOutException extends SubscriptionException {
+public class SubscriptionConnectionException extends
SubscriptionRuntimeCriticalException {
- public SubscriptionPollTimeOutException(String message) {
+ public SubscriptionConnectionException(final String message) {
super(message);
}
- protected SubscriptionPollTimeOutException(String message, long timeStamp) {
- super(message, timeStamp);
+ public SubscriptionConnectionException(final String message, final Throwable
cause) {
+ super(message, cause);
}
@Override
- public boolean equals(Object obj) {
- return obj instanceof SubscriptionPollTimeOutException
- && Objects.equals(getMessage(), ((SubscriptionPollTimeOutException)
obj).getMessage())
- && Objects.equals(getTimeStamp(), ((SubscriptionPollTimeOutException)
obj).getTimeStamp());
- }
-
- @Override
- public int hashCode() {
- return Objects.hash(getMessage(), getTimeStamp());
+ public boolean equals(final Object obj) {
+ return obj instanceof SubscriptionConnectionException
+ && Objects.equals(getMessage(), ((SubscriptionConnectionException)
obj).getMessage())
+ && Objects.equals(getTimeStamp(), ((SubscriptionConnectionException)
obj).getTimeStamp());
Review Comment:
hashCode?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
