Pengzna commented on code in PR #12355:
URL: https://github.com/apache/iotdb/pull/12355#discussion_r1618434874


##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/consensus/DataRegionConsensusImpl.java:
##########
@@ -132,6 +139,39 @@ private static ConsensusConfig buildConsensusConfig() {
                               
CONF.getRegionMigrationSpeedLimitBytesPerSecond())
                           .build())
                   .build())
+          .setPipeConsensusConfig(
+              PipeConsensusConfig.newBuilder()
+                  .setRPC(
+                      PipeConsensusConfig.RPC
+                          .newBuilder()
+                          
.setConnectionTimeoutInMs(CONF.getConnectionTimeoutInMS())
+                          
.setRpcSelectorThreadNum(CONF.getRpcSelectorThreadCount())
+                          
.setRpcMinConcurrentClientNum(CONF.getRpcMinConcurrentClientNum())
+                          
.setRpcMaxConcurrentClientNum(CONF.getRpcMaxConcurrentClientNum())
+                          
.setIsRpcThriftCompressionEnabled(CONF.isRpcThriftCompressionEnable())
+                          
.setSelectorNumOfClientManager(CONF.getSelectorNumOfClientManager())
+                          .setThriftServerAwaitTimeForStopService(
+                              CONF.getThriftServerAwaitTimeForStopService())
+                          .setThriftMaxFrameSize(CONF.getThriftMaxFrameSize())
+                          
.setMaxClientNumForEachNode(CONF.getMaxClientNumForEachNode())
+                          .build())
+                  .setPipe(
+                      PipeConsensusConfig.Pipe.newBuilder()
+                          .setExtractorPluginName(
+                              
BuiltinPipePlugin.IOTDB_EXTRACTOR.getPipePluginName())
+                          .setProcessorPluginName(
+                              
BuiltinPipePlugin.PIPE_CONSENSUS_PROCESSOR.getPipePluginName())
+                          .setConnectorPluginName(
+                              
BuiltinPipePlugin.PIPE_CONSENSUS_ASYNC_CONNECTOR.getPipePluginName())
+                          // name
+                          .setConsensusPipeDispatcher(new 
ConsensusPipeDataNodeDispatcher())
+                          .setConsensusPipeGuardian(new 
ConsensusPipeDataNodeRuntimeAgentGuardian())
+                          .setConsensusPipeSelector(() -> 
PipeAgent.task().getAllConsensusPipe())
+                          
.setConsensusPipeReceiver(PipeAgent.receiver().pipeConsensus())
+                          .setProgressIndexManager(new 
ProgressIndexDataNodeManager())
+                          .setConsensusPipeGuardJobIntervalInSeconds(300) // 
TODO: move to config

Review Comment:
   it makes sense. fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to