jt2594838 commented on code in PR #12476:
URL: https://github.com/apache/iotdb/pull/12476#discussion_r1625219915
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/buffer/WALBuffer.java:
##########
@@ -521,8 +520,9 @@ public void run() {
forceFlag, syncingBuffer.position(), syncingBuffer.capacity(),
usedRatio * 100);
// flush buffer to os
+ double compressionRate = 1.0;
try {
- currentWALFileWriter.write(syncingBuffer, info.metaData);
+ compressionRate = currentWALFileWriter.write(syncingBuffer,
info.metaData);
Review Comment:
"metric" here does not refer to IoTDB metrics for monitoring, but exactly
the "effective information of wal file".
The idea is that the compression throughout is as important as the
compression ratio.
If you decide to only use one, then you should give a good reason.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
