OneSizeFitsQuorum commented on code in PR #12638:
URL: https://github.com/apache/iotdb/pull/12638#discussion_r1625269718
##########
iotdb-core/node-commons/src/assembly/resources/conf/iotdb-system.properties:
##########
@@ -1849,3 +1849,23 @@ data_replication_factor=1
# Default value is -1, which means no limit.
# Datatype: int
# load_write_throughput_bytes_per_second=-1
+
+
+
+####################
+### Retry Configuration
+####################
+
+# The maximum retrying time for write request remotely dispatching, time unit
is milliseconds.
+# It only takes effect for write request remotely dispatching, not including
locally dispatching and query
+# Set to 0 or negative number to disable remote dispatching write request
retrying
+# We will sleep for some time between each retry, 100ms, 200ms, 400ms, 800ms
and so on, util reaching 20,000ms, we won't increase the sleeping time any more
Review Comment:
default is 60000ms?
##########
iotdb-core/node-commons/src/assembly/resources/conf/iotdb-system.properties:
##########
@@ -1849,3 +1849,23 @@ data_replication_factor=1
# Default value is -1, which means no limit.
# Datatype: int
# load_write_throughput_bytes_per_second=-1
+
+
+
+####################
+### Retry Configuration
Review Comment:
Dispatch Retry Configuration？
##########
iotdb-core/node-commons/src/assembly/resources/conf/iotdb-system.properties:
##########
@@ -1849,3 +1849,23 @@ data_replication_factor=1
# Default value is -1, which means no limit.
# Datatype: int
# load_write_throughput_bytes_per_second=-1
+
+
Review Comment:
maybe one empty line is enough?
##########
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/service/metric/PerformanceOverviewMetrics.java:
##########
@@ -127,11 +129,20 @@ public void recordScheduleCost(long costTimeInNanos) {
PERFORMANCE_OVERVIEW_SCHEDULE_DETAIL,
Tag.STAGE.toString(),
REMOTE_SCHEDULE));
+ metricInfoMap.put(
+ REMOTE_RETRY_SLEEP,
+ new MetricInfo(
+ MetricType.TIMER,
+ PERFORMANCE_OVERVIEW_SCHEDULE_DETAIL,
+ Tag.STAGE.toString(),
+ REMOTE_RETRY_SLEEP));
}
private Timer localScheduleTimer = DoNothingMetricManager.DO_NOTHING_TIMER;
private Timer remoteScheduleTimer = DoNothingMetricManager.DO_NOTHING_TIMER;
Review Comment:
same
##########
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/service/metric/PerformanceOverviewMetrics.java:
##########
@@ -112,6 +112,8 @@ public void recordScheduleCost(long costTimeInNanos) {
private static final String LOCAL_SCHEDULE = "local_scheduler";
private static final String REMOTE_SCHEDULE = "remote_scheduler";
Review Comment:
do not need empty line？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
