Caideyipi commented on code in PR #12932:
URL: https://github.com/apache/iotdb/pull/12932#discussion_r1680471197
##########
integration-test/src/test/java/org/apache/iotdb/pipe/it/autocreate/IoTDBPipeAlterIT.java:
##########
@@ -53,7 +53,7 @@ public void testBasicAlterPipe() throws Exception {
// Create pipe
final String sql =
String.format(
- "create pipe a2b with processor
('processor'='do-nothing-processor') with sink ('node-urls'='%s')",
+ "create pipe a2b with source ('source'='iotdb-source',
'source.pattern'='root.test1', 'source.path'='root.test2.**') with processor
('processor'='do-nothing-processor') with sink ('node-urls'='%s')",
Review Comment:
Typically a pipe won't have "pattern" and "path" parameters together. The
"path" one can be omitted here. And we can modify "pattern" instead of "path"
too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
