Caideyipi commented on code in PR #12969:
URL: https://github.com/apache/iotdb/pull/12969#discussion_r1683679151
##########
iotdb-core/antlr/src/main/antlr4/org/apache/iotdb/db/qp/sql/IoTDBSqlParser.g4:
##########
@@ -694,6 +694,14 @@ viewSourcePaths
| selectClause fromClause
;
+ifNotExists
Review Comment:
There are "IF NOT EXISTS"s in our relational sql, and seems that they do not
add the "ifNotExists" and "ifExists" definition. Like:
createDbStatement
: CREATE DATABASE (IF NOT EXISTS)? database=identifier (WITH properties)?
;
##########
iotdb-protocol/thrift-confignode/src/main/thrift/confignode.thrift:
##########
@@ -673,10 +673,12 @@ struct TCreatePipePluginReq {
3: required string jarName
4: required binary jarFile
5: required string jarMD5
+ 6: optional bool isNotExists
}
struct TDropPipePluginReq {
1: required string pluginName
+ 2: optional bool isExists
Review Comment:
ifExists
##########
iotdb-core/antlr/src/main/antlr4/org/apache/iotdb/db/qp/sql/SqlLexer.g4:
##########
@@ -294,6 +294,10 @@ EXTRACTOR
: E X T R A C T O R
;
+EXISTS
Review Comment:
Be aware to keep the dictionary sequence.
##########
iotdb-core/antlr/src/main/antlr4/org/apache/iotdb/db/qp/sql/SqlLexer.g4:
##########
@@ -946,6 +950,10 @@ INF
: I N F
;
+IF
Review Comment:
Same as above.
##########
iotdb-protocol/thrift-confignode/src/main/thrift/confignode.thrift:
##########
@@ -673,10 +673,12 @@ struct TCreatePipePluginReq {
3: required string jarName
4: required binary jarFile
5: required string jarMD5
+ 6: optional bool isNotExists
Review Comment:
ifNotExists
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
