chrisdutz commented on code in PR #13302:
URL: https://github.com/apache/iotdb/pull/13302#discussion_r1732464234
##########
iotdb-core/ainode/pom.xml:
##########
@@ -56,81 +56,73 @@
</dependency>
</dependencies>
<build>
- <resources>
- <resource>
- <filtering>true</filtering>
- <directory>${basedir}/resources</directory>
- <includes>
- <include>pyproject.toml</include>
- </includes>
- </resource>
- </resources>
<plugins>
- <plugin>
- <groupId>org.apache.maven.plugins</groupId>
- <artifactId>maven-checkstyle-plugin</artifactId>
- <configuration>
- <skip>true</skip>
- </configuration>
- </plugin>
<!-- clean thrift folder -->
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-clean-plugin</artifactId>
<configuration>
<filesets>
<fileset>
- <directory>iotdb</directory>
- <includes>
- <include>thrift/</include>
- </includes>
- <followSymlinks>false</followSymlinks>
+ <directory>dist</directory>
</fileset>
<fileset>
- <directory>./</directory>
+ <directory>iotdb</directory>
<includes>
- <include>LICENSE</include>
+ <include>conf/</include>
+ <include>thrift/</include>
</includes>
</fileset>
<fileset>
<directory>target</directory>
- <excludes>
- <exclude>**/*ainode*</exclude>
- </excludes>
</fileset>
<fileset>
- <directory>dist</directory>
+ <directory>venv</directory>
</fileset>
</filesets>
</configuration>
</plugin>
- <!-- generate git.properties to provide build info -->
<plugin>
- <groupId>pl.project13.maven</groupId>
- <artifactId>git-commit-id-plugin</artifactId>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-checkstyle-plugin</artifactId>
<configuration>
- <generateGitPropertiesFile>true</generateGitPropertiesFile>
-
<generateGitPropertiesFilename>${project.basedir}/iotdb/conf/git.properties</generateGitPropertiesFilename>
- <includeOnlyProperties>
-
<includeOnlyProperty>^git.commit.id.abbrev$</includeOnlyProperty>
- <includeOnlyProperty>^git.dirty$</includeOnlyProperty>
- </includeOnlyProperties>
- <commitIdGenerationMode>full</commitIdGenerationMode>
- <failOnNoGitDirectory>false</failOnNoGitDirectory>
- <offline>true</offline>
- <gitDescribe>
- <dirty>-dev</dirty>
- </gitDescribe>
+ <skip>true</skip>
</configuration>
+ </plugin>
+ <plugin>
+ <groupId>org.codehaus.gmaven</groupId>
+ <artifactId>groovy-maven-plugin</artifactId>
<executions>
+ <!--
+ The python versioning follows slightly different rules
than Maven.
+ This little script makes sure the python project file is
always in
+ sync with the maven module.
+ -->
<execution>
+ <id>sync-python-version</id>
+ <phase>validate</phase>
<goals>
- <goal>revision</goal>
+ <goal>execute</goal>
</goals>
+ <configuration>
+ <source>resources/syncPythonVersion.groovy</source>
Review Comment:
Yeah ... that was the other thing I found ;-) Should already be fixed, if
you update.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
