Caideyipi commented on code in PR #13433:
URL: https://github.com/apache/iotdb/pull/13433#discussion_r1751748346
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/task/builder/PipeDataNodeTaskBuilder.java:
##########
@@ -141,4 +158,37 @@ private PipeParameters blendUserAndSystemParameters(final
PipeParameters userPar
blendedParameters.putAll(systemParameters);
return new PipeParameters(blendedParameters);
}
+
+ private void checkConflict(
+ final PipeParameters extractorParameters, final PipeParameters
connectorParameters) {
+
+ try {
+ final Pair<Boolean, Boolean> insertionDeletionListeningOptionPair =
+
DataRegionListeningFilter.parseInsertionDeletionListeningOptionPair(extractorParameters);
+ if (!insertionDeletionListeningOptionPair.left) {
Review Comment:
Deletion is maybe "right"?
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/task/builder/PipeDataNodeTaskBuilder.java:
##########
@@ -141,4 +158,37 @@ private PipeParameters blendUserAndSystemParameters(final
PipeParameters userPar
blendedParameters.putAll(systemParameters);
return new PipeParameters(blendedParameters);
}
+
+ private void checkConflict(
+ final PipeParameters extractorParameters, final PipeParameters
connectorParameters) {
+
+ try {
+ final Pair<Boolean, Boolean> insertionDeletionListeningOptionPair =
+
DataRegionListeningFilter.parseInsertionDeletionListeningOptionPair(extractorParameters);
+ if (!insertionDeletionListeningOptionPair.left) {
+ return;
+ }
+ } catch (IllegalPathException e) {
+ LOGGER.warn(
+ "PipeDataNodeTaskBuilder failed to parse 'inclusion' and 'exclusion'
parameters: {}",
+ e.getMessage());
+ return;
+ }
+
+ final Boolean isRealtime =
+ connectorParameters.getBooleanByKeys(
+ PipeConnectorConstant.CONNECTOR_REALTIME_FIRST_KEY,
+ PipeConnectorConstant.SINK_REALTIME_FIRST_KEY);
+ if (isRealtime == null) {
+
connectorParameters.addAttribute(PipeConnectorConstant.CONNECTOR_REALTIME_FIRST_KEY,
"false");
+ LOGGER.warn(
+ "PipeDataNodeTaskBuilder: When 'inclusion' contains 'data.delete',
'realtime-first' is defaulted to 'false' to prevent sync issues after
deletion.");
Review Comment:
This shall not print warn log because it's a normal circumstance. Either
delete this or change it to info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
