Caideyipi commented on code in PR #13600:
URL: https://github.com/apache/iotdb/pull/13600#discussion_r1774298944
##########
iotdb-core/relational-grammar/src/main/antlr4/org/apache/iotdb/db/relational/grammar/sql/RelationalSql.g4:
##########
@@ -713,26 +827,26 @@ nonReserved
// IMPORTANT: this rule must only contain tokens. Nested rules are not
supported. See SqlParser.exitNonReserved
: ABSENT | ADD | ADMIN | AFTER | ALL | ANALYZE | ANY | ARRAY | ASC | AT |
ATTRIBUTE | AUTHORIZATION
| BEGIN | BERNOULLI | BOTH
- | CACHE | CALL | CALLED | CASCADE | CATALOG | CATALOGS | CHAR | CHARACTER
| CHARSET | CLEAR | CLUSTER | CLUSTERID | COLUMN | COLUMNS | COMMENT | COMMIT |
COMMITTED | CONDITION | CONDITIONAL | CONFIGNODES | CONFIGURATION | COPARTITION
| COUNT | CURRENT
+ | CACHE | CALL | CALLED | CASCADE | CATALOG | CATALOGS | CHAR | CHARACTER
| CHARSET | CLEAR | CLUSTER | CLUSTERID | COLUMN | COLUMNS | COMMENT | COMMIT |
COMMITTED | CONDITION | CONDITIONAL | CONFIGNODES | CONFIGURATION | COPARTITION
| COUNT | CURRENT | CONNECTOR
| DATA | DATABASE | DATABASES | DATANODES | DATE | DAY | DECLARE | DEFAULT
| DEFINE | DEFINER | DENY | DESC | DESCRIPTOR | DETAILS| DETERMINISTIC |
DEVICES | DISTRIBUTED | DO | DOUBLE
- | ELSEIF | EMPTY | ENCODING | ERROR | EXCLUDING | EXPLAIN
+ | ELSEIF | EMPTY | ENCODING | ERROR | EXCLUDING | EXPLAIN | EXTRACTOR
| FETCH | FILL | FILTER | FINAL | FIRST | FLUSH | FOLLOWING | FORMAT |
FUNCTION | FUNCTIONS
| GRACE | GRANT | GRANTED | GRANTS | GRAPHVIZ | GROUPS
| HOUR
| ID | INDEX | INDEXES | IF | IGNORE | IMMEDIATE | INCLUDING | INITIAL |
INPUT | INTERVAL | INVOKER | IO | ITERATE | ISOLATION
| JSON
| KEEP | KEY | KEYS | KILL
| LANGUAGE | LAST | LATERAL | LEADING | LEAVE | LEVEL | LIMIT | LINEAR |
LOAD | LOCAL | LOGICAL | LOOP
- | MAP | MATCH | MATCHED | MATCHES | MATCH_RECOGNIZE | MATERIALIZED |
MEASUREMENT | MEASURES | MERGE | MICROSECOND | MIGRATE | MILLISECOND | MINUTE |
MONTH
+ | MAP | MATCH | MATCHED | MATCHES | MATCH_RECOGNIZE | MATERIALIZED |
MEASUREMENT | MEASURES | MERGE | MICROSECOND | MIGRATE | MILLISECOND | MINUTE |
MONTH | MODIFY
Review Comment:
May use lexicographical order in the whole file?
##########
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/config/constant/PipeExtractorConstant.java:
##########
@@ -24,6 +24,12 @@ public class PipeExtractorConstant {
public static final String EXTRACTOR_KEY = "extractor";
public static final String SOURCE_KEY = "source";
+ public static final String EXTRACTOR_DIALECT_KEY = "extractor.dialect";
Review Comment:
Seemingly this is not decided by the model used in creation and is left for
the users to fill in?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
