FearfulTomcat27 opened a new pull request, #13845: URL: https://github.com/apache/iotdb/pull/13845
This pull request includes several changes to the `evaluateWithSelection` and `doTransform` methods across multiple transformer classes in the `iotdb-core` module. The changes primarily focus on improving the consistency and correctness of how the position count is obtained from columns. ### Consistency Improvements: * [`iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/transformation/dag/column/binary/LogicAndColumnTransformer.java`](diffhunk://#diff-c54acc8c312ac148943810046c419a58e13d57402c8e4dd40dd2d53595a8d01aL39-R40): Moved the assignment of `leftColumn` to ensure it is consistently placed after obtaining the position count. * [`iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/transformation/dag/column/binary/LogicOrColumnTransformer.java`](diffhunk://#diff-f8664105db52e335df7b40037af2198f4cd1d8364b59edf6cb73d7315b39e2edL39-R40): Similar adjustment as in `LogicAndColumnTransformer` to ensure consistent placement of `leftColumn` assignment. ### Correctness Improvements: * [`iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/transformation/dag/column/multi/LogicalAndMultiColumnTransformer.java`](diffhunk://#diff-1240f14b88650a14753736ebe01b9a1ccc6e8c5182e2b2e9b21eece67d6810c1L57-R57): Changed the source of `positionCount` from `columnTransformerList` to `childrenColumns` to correctly reflect the position count. * [`iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/transformation/dag/column/multi/LogicalOrMultiColumnTransformer.java`](diffhunk://#diff-f812c4f0a951360a720a54b57b19333fa909757d53aa60d914238002240bf2d1L57-R57): Updated the source of `positionCount` from `columnTransformerList` to `childColumns` for accuracy. * [`iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/transformation/dag/column/multi/MappableUDFColumnTransformer.java`](diffhunk://#diff-179f6b7a999c6e7c3157697928c54e7a589275ed4ffdee940e2fec9ef9bd3bd0L70-R70): Corrected the source of `positionCount` from `inputColumnTransformers` to `columns` to ensure the correct position count is used. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
