SteveYurongSu commented on code in PR #13984:
URL: https://github.com/apache/iotdb/pull/13984#discussion_r1827251338


##########
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/conf/CommonDescriptor.java:
##########
@@ -266,6 +266,11 @@ private void loadPipeProps(Properties properties) {
             properties.getProperty(
                 "pipe_hardlink_wal_enabled",
                 Boolean.toString(config.getPipeHardLinkWALEnabled()))));
+    config.setPipeFileReceiverFsyncEnabled(
+        Boolean.parseBoolean(
+            properties.getProperty(
+                "pipe_file_receiver_fsync_enabled",

Review Comment:
   This kind of parameter adjustment may bring problem of correctness, so it is 
better to treat it as a secret parameter. It is deliberately not placed in the 
configuration file.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to