OneSizeFitsQuorum commented on code in PR #13983:
URL: https://github.com/apache/iotdb/pull/13983#discussion_r1829111397
##########
iotdb-core/datanode/src/assembly/resources/sbin/remove-datanode.bat:
##########
@@ -125,7 +125,7 @@ goto :eof
rem echo CLASSPATH: %CLASSPATH%
-"%JAVA_HOME%\bin\java" %JAVA_OPTS% %IOTDB_HEAP_OPTS% -cp %CLASSPATH%
%IOTDB_JMX_OPTS% %MAIN_CLASS% %CONF_PARAMS%
+"%JAVA_HOME%\bin\java" %JAVA_OPTS% %IOTDB_HEAP_OPTS% -Xms2g -Xmx2g -cp
%CLASSPATH% %IOTDB_JMX_OPTS% %MAIN_CLASS% %CONF_PARAMS%
Review Comment:
Can we set two new variables in this configuration file to indicate
out-of-heap and in-heap memory? In case the 2g memory is not enough in some
scenarios, users can further reduce the memory usage manually
##########
iotdb-core/datanode/src/assembly/resources/sbin/remove-datanode.sh:
##########
@@ -73,7 +73,7 @@ launch_service()
iotdb_parms="$iotdb_parms -Dname=iotdb\.IoTDB"
iotdb_parms="$iotdb_parms -DIOTDB_LOG_DIR=${IOTDB_LOG_DIR}"
- exec "$JAVA" $iotdb_parms $IOTDB_JMX_OPTS -cp "$CLASSPATH" "$class"
$PARAMS
+ exec "$JAVA" $iotdb_parms $IOTDB_JMX_OPTS -Xms2g -Xmx2g -cp
"$CLASSPATH" "$class" $PARAMS
Review Comment:
same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
