Cpaulyz commented on code in PR #14135:
URL: https://github.com/apache/iotdb/pull/14135#discussion_r1857892730
##########
iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/udf/UDFTable.java:
##########
@@ -19,99 +19,101 @@
package org.apache.iotdb.commons.udf;
-import
org.apache.iotdb.commons.udf.builtin.BuiltinTimeSeriesGeneratingFunction;
+import org.apache.iotdb.common.rpc.thrift.Model;
import org.apache.iotdb.commons.udf.service.UDFClassLoader;
import org.apache.iotdb.commons.utils.TestOnly;
+import org.apache.tsfile.utils.Pair;
import org.apache.tsfile.utils.ReadWriteIOUtils;
import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream;
+import java.util.ArrayList;
import java.util.List;
import java.util.Map;
import java.util.concurrent.ConcurrentHashMap;
import java.util.stream.Collectors;
+/**
+ * UDFTable is a table that stores UDF information. On DataNode, it stores all
UDF information. On
+ * ConfigNode, it does not store built-in UDF information.
+ */
public class UDFTable {
- private final Map<String, UDFInformation> udfInformationMap;
- /** maintain a map for creating instance */
- private final Map<String, Class<?>> functionToClassMap;
+ /** functionName -> information * */
+ private final Map<Pair<Model, String>, UDFInformation> udfInformationMap;
+
+ /** maintain a map for creating instance, functionName -> class */
+ private final Map<Pair<Model, String>, Class<?>> functionToClassMap;
Review Comment:
Done. Use `Map<Model, Map<String, UDFInformation>>` now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
