luoluoyuyu commented on code in PR #14168:
URL: https://github.com/apache/iotdb/pull/14168#discussion_r1865909178
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/processor/downsampling/sdt/SwingingDoorTrendingFilter.java:
##########
@@ -144,11 +143,17 @@ private boolean tryFilter(final long timestamp, final T
value) {
return false;
}
- private void reset(final long timestamp, final T value) {
+ public void reset(final long arrivalTime, final long timestamp, final Object
value) {
upperDoor = Double.MIN_VALUE;
lowerDoor = Double.MAX_VALUE;
- lastStoredTimestamp = timestamp;
+ lastPointEventTime = timestamp;
lastStoredValue = value;
+
+ lastPointArrivalTime = arrivalTime;
+ }
+
+ public long estimatedMemory() {
+ return estimatedMemory + 64;
Review Comment:
Define an enumeration save type and ChangeValue processing function
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/agent/plugin/dataregion/PipeDataRegionProcessorConstructor.java:
##########
@@ -51,7 +51,7 @@ protected void initConstructors() {
SwingingDoorTrendingSamplingProcessor::new);
pluginConstructors.put(
BuiltinPipePlugin.CHANGING_VALUE_SAMPLING_PROCESSOR.getPipePluginName(),
- ChangingValueSamplingProcessor::new);
+ ChangingPointSamplingProcessor::new);
pluginConstructors.put(
Review Comment:
And ChangingValue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
