lancelly commented on code in PR #14148: URL: https://github.com/apache/iotdb/pull/14148#discussion_r1867097898
########## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/join/merge/comparator/JoinKeyComparator.java: ########## @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iotdb.db.queryengine.execution.operator.process.join.merge.comparator; + +import org.apache.tsfile.read.common.block.TsBlock; + +public interface JoinKeyComparator { + + boolean lessThan( + TsBlock left, + int leftColumnIndex, + int leftRowIndex, + TsBlock right, + int rightColumnIndex, + int rightRowIndex); + + boolean equalsTo( + TsBlock left, + int leftColumnIndex, + int leftRowIndex, + TsBlock right, + int rightColumnIndex, + int rightRowIndex); + + boolean lessThanOrEqual( Review Comment: Fixed. ########## iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/execution/operator/process/join/merge/comparator/DescBinaryTypeJoinKeyComparator.java: ########## @@ -0,0 +1,78 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.iotdb.db.queryengine.execution.operator.process.join.merge.comparator; + +import org.apache.tsfile.read.common.block.TsBlock; + +public class DescBinaryTypeJoinKeyComparator implements JoinKeyComparator { + + private static final DescBinaryTypeJoinKeyComparator INSTANCE = + new DescBinaryTypeJoinKeyComparator(); + + private DescBinaryTypeJoinKeyComparator() { + // hide constructor + } + + public static DescBinaryTypeJoinKeyComparator getInstance() { + return INSTANCE; + } + + @Override + public boolean lessThan( + TsBlock left, + int leftColumnIndex, + int leftRowIndex, + TsBlock right, + int rightColumnIndex, + int rightRowIndex) { + return left.getColumn(leftColumnIndex) + .getBinary(leftRowIndex) + .compareTo(right.getColumn(rightColumnIndex).getBinary(rightRowIndex)) + > 0; + } + + @Override + public boolean equalsTo( + TsBlock left, + int leftColumnIndex, + int leftRowIndex, + TsBlock right, + int rightColumnIndex, + int rightRowIndex) { + return left.getColumn(leftColumnIndex) + .getBinary(leftRowIndex) + .compareTo(right.getColumn(rightColumnIndex).getBinary(rightRowIndex)) + == 0; Review Comment: Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
