shizy818 commented on code in PR #14265:
URL: https://github.com/apache/iotdb/pull/14265#discussion_r1868990750
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/utils/datastructure/QuickBinaryTVList.java:
##########
@@ -31,9 +29,9 @@ public int compare(int idx1, int idx2) {
@Override
public void swap(int p, int q) {
- Binary valueP = getBinary(p);
+ int valueP = getValueIndex(p);
long timeP = getTime(p);
- Binary valueQ = getBinary(q);
+ int valueQ = getValueIndex(q);
Review Comment:
Maybe I can to do this change later, and move common methods to XXXSort.
```
[HTHou](https://github.com/HTHou) [Dec 3,
2024](https://github.com/apache/iotdb/pull/14265#discussion_r1866983823)
这个方法看起来各个实现类里都变成一样的了,是不是可以放到 TimSort.java 里
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]